Re: [PATCH] config.c: change the function signature of `git_config_string()`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 22, 2014, 15:53 UTC
- Message-ID
- <xmqqoawhgzky.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <vpqsiltsjm7.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> OK, it seems I got convinced too quickly by Junio ;-). The function > produces a char * that can be modified, but it also receives a value, > and the function should keep the "const" to allow passing "const char > *".
Don't blame me. I never suggested to touch that existing function, with existing call sites.