[PATCH] config.c: change the function signature of `git_config_string()`
- From
Tanay Abhra <tanayabh@gmail.com>
- Date
- Jul 22, 2014, 10:49 UTC
- Message-ID
- <1406026196-17877-1-git-send-email-tanayabh@gmail.com>
`git_config_string()` output parameter `dest` is declared as a const which is unnecessary as the caller of the function is given a strduped string which can be modified without causing any harm.
Thus, remove the const from the function signature.
Signed-off-by: Tanay Abhra <tanayabh@gmail.com> --- cache.h | 2 +- config.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cache.h b/cache.h index 92fc9f1..93d357a 100644 --- a/cache.h +++ b/cache.h @@ -1303,7 +1303,7 @@ extern unsigned long git_config_ulong(const char *, const char *); extern int git_config_bool_or_int(const char *, const char *, int *); extern int git_config_bool(const char *, const char *); extern int git_config_maybe_bool(const char *, const char *); -extern int git_config_string(const char **, const char *, const char *); +extern int git_config_string(char **, const char *, const char *); extern int git_config_pathname(const char **, const char *, const char *); extern int git_config_set_in_file(const char *, const char *, const char *); extern int git_config_set(const char *, const char *); diff --git a/config.c b/config.c index ba882a1..25e28a7 100644 --- a/config.c +++ b/config.c @@ -633,7 +633,7 @@ int git_config_bool(const char *name, const char *value) return !!git_config_bool_or_int(name, value, &discard); } -int git_config_string(const char **dest, const char *var, const char *value) +int git_config_string(char **dest, const char *var, const char *value) { if (!value) return config_error_nonbool(var);
-- 1.9.0.GIT