From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Tue, 02 Jun 2015 14:17:52 GMT
Subject: Re: [PATCH/RFCv3 1/2] git-rebase -i: add command "drop" to remove a commit
Message-ID: <vpqeglujisv.fsf@anie.imag.fr>
In-Reply-To: <1433252180-25591-1-git-send-email-remi.galan-alfonso@ensimag.grenoble-inp.fr>

Galan Rémi <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:

> +test_expect_success 'drop' '

Please, be more descriptive in the first argument of
test_expect_success. It's usually a good thing to say not only what the
test stresses but also what the expected behavior is.

test_expect_success 'drop actually drops the lines' '
	...
'

?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/