Re: [PATCH] Do _not_ call unlink on a directory

From

Matthieu Moy <matthieu.moy@imag.fr>

Date

Jul 16, 2007, 17:18 UTC

Message-ID

<vpqd4yss1vo.fsf@bauges.imag.fr>

In-Reply-To

<11846059721204-git-send-email-sithglan@stud.uni-erlangen.de>

Thomas Glanzmann <sithglan@stud.uni-erlangen.de> writes:

I believe you still have a race condition if ...

> -				if (len > state->base_dir_len && state->force && !unlink(buf) && !mkdir(buf, 0777))
> -					continue;

... buf exists here as a file ...

>  				if (!stat(buf, &st) && S_ISDIR(st.st_mode))
>  					continue; /* ok */

... and became a directory here.

> +				if (len > state->base_dir_len && state->force && !unlink(buf) && !mkdir(buf, 0777))
> +					continue;

But that's quite unlikely to happen. And I have no fix to propose.

-- 
Matthieu