Re: [PATCH] Do _not_ call unlink on a directory

From: Thomas Glanzmann <thomas@glanzmann.de>
Date: Jul 17, 2007, 20:27 UTC
Message-ID: <20070717202754.GB25037@cip.informatik.uni-erlangen.de>
In-Reply-To: <7vlkdeang0.fsf@assigned-by-dhcp.cox.net>

Hello Junio,

> Ahhhh, by "testing", I meant "runnnig the testsuite shipped with
> the source".  Both of your patches were failing in somewhere in
> t2000 series of tests.

That was the last time, I am going to submit a patch _without_ running the whole testsuite before. I hate it myself when other people don't do the obvious tests and break something that worked before.

> I am thinking that this fix should go to 'maint' and merged to
> 'master', as it is a grave problem in at least one setup.

Thanks. For packages that I distribute, I fixed it of course by myself. And to be precise I use git on Solaris a lot by myself but I don't work as root so the bug never showed up before and as you can see by the pastes that I provided to track down the bug I have

	if [ $UID -eq 0 ]; then
		export PS1="(${PROMPT_RED}\h${PROMPT_END}) [${PROMPT_BLUE}\w${PROMPT_END}] ";
		alias bk='echo DO *NOT* RUN BK AS ROOT'
		alias git='echo DO *NOT* RUN GIT AS ROOT'
		alias links='echo DO *NOT* RUN LINKS AS ROOT'
		alias elinks='echo DO *NOT* RUN ELINKS AS ROOT'
	...

in my distributed environment. But my coworker who I "show" git to work a lot as root. A very bad habbit that is hard to get rid of. Btw. I prepare to setup a automatic build script which I am going to let run automatic on a daily basis so that I catch Solaris compile problems early and report them to you.

	Thomas