Re: [PATCH] Do _not_ call unlink on a directory

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2007, 18:34 UTC
Message-ID: <7vlkdeang0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070717101527.GB7774@cip.informatik.uni-erlangen.de>

Thomas Glanzmann <thomas@glanzmann.de> writes:

Show 27 quoted lines

>> I wonder if anybody involved in the discussion has actually
>> tested this patch (or the other one, that has the same problem)?
>
> I tested it. But I did not test it with symlinks.
>
>> Does the following replacement work for you?  It adds far more lines
>> than your version, but they are mostly comments to make it clear why
>> we do things this way.
>
> Yes, it does. Excuse the delay but my build machine is not the fastest.
>
> 	(faui04a) [/var/tmp] git clone ~/work/repositories/public/easix.git test-10
> 	Initialized empty Git repository in /var/tmp/test-10/.git/
> 	remote: Generating pack...
> 	remote: Done counting 317 objects.
> 	remote: Deltifying 317 objects...
> 	remote: te: % (317/317) done: ) done
> 	Indexing 317 objects...
> 	remote: Total 317 (delta 182), reused 278 (delta 157)
> 	100% (317/317) done
> 	Resolving 182 deltas...
> 	100% (182/182) done
> 	(faui04a) [/var/tmp] cd test-10
> 	./test-10
> 	(faui04a) [/var/tmp/test-10] git status
> 	# On branch master
> 	nothing to commit (working directory clean)

Ahhhh, by "testing", I meant "runnnig the testsuite shipped with the source". Both of your patches were failing in somewhere in t2000 series of tests.

> I rebased your patch on top of current HEAD (as I can access it on
> git.kernel.org) and removed trailing whitspace from one line (git-apply
> complained)

I am thinking that this fix should go to 'maint' and merged to 'master', as it is a grave problem in at least one setup.