git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Do _not_ call unlink on a directory

From
Brian Downing <bdowning@lavos.net>
Date
Jul 16, 2007, 17:42 UTC
Message-ID
<20070716174239.GG19073@lavos.net>
In-Reply-To
<11846075213759-git-send-email-sithglan@stud.uni-erlangen.de>
On Mon, Jul 16, 2007 at 07:38:41PM +0200, Thomas Glanzmann wrote:
>  	const char *slash = path;
> +        struct stat st;
>  		memcpy(buf, path, len);
>  		buf[len] = 0;
> +                if (!stat(buf, &st) && S_ISDIR(st.st_mode))
> +                        continue; /* ok */
You've got some whitespace damage here.  Git's style is to use tabs.
-bcd
Previous: Jan-Benedict GlawNext: Thomas Glanzmann
Message 17 of 30 in “Do _not_ call unlink on a directory”
  1. Do _not_ call unlink on a directoryThomas Glanzmann, Jul 16, 2007
  2. Matthieu MoyJul 16, 2007
  3. Scott LambJul 16, 2007
  4. Thomas GlanzmannJul 16, 2007
  5. Thomas GlanzmannJul 16, 2007
  6. Linus TorvaldsJul 16, 2007
  7. Thomas GlanzmannJul 16, 2007
  8. Linus TorvaldsJul 16, 2007
  9. Thomas GlanzmannJul 16, 2007
  10. Scott LambJul 16, 2007
  11. Linus TorvaldsJul 16, 2007
  12. Scott LambJul 16, 2007
  13. Linus TorvaldsJul 16, 2007
  14. Linus TorvaldsJul 16, 2007
  15. Do _not_ call unlink on a directoryThomas Glanzmann, Jul 16, 2007
  16. Jan-Benedict GlawJul 16, 2007
  17. Brian DowningJul 16, 2007
  18. Thomas GlanzmannJul 16, 2007
  19. Linus TorvaldsJul 16, 2007
  20. Brian DowningJul 16, 2007
  21. Linus TorvaldsJul 16, 2007
  22. David KastrupJul 17, 2007
  23. Junio C HamanoJul 17, 2007
  24. Junio C HamanoJul 17, 2007
  25. Thomas GlanzmannJul 17, 2007
  26. Junio C HamanoJul 17, 2007
  27. Thomas GlanzmannJul 17, 2007
  28. Johannes SixtJul 18, 2007
  29. Thomas GlanzmannJul 18, 2007
  30. Linus TorvaldsJul 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.