Re: [PATCH 3/3 v4] Add global and system-wide gitattributes

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Aug 31, 2010, 22:41 UTC
Message-ID: <vpqbp8i2yns.fsf@bauges.imag.fr>
In-Reply-To: <1283210123-19752-3-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> This version doesn't touch config.c, and calls git_config with a
> trivial callback reading only the core.attributesfile variable.

I see that pu has a variant of my fix:

  17cd572 fixup! Add global and system-wide gitattributes

(is the fixup! here on purpose, or is it a failed rebase -i?)

Junio: your fixup fixes the git_config issue, but doesn't have the
test that my patch have. The difference is that your fixup moves the
global variable attributes_file in attr.c, which sounds like a good
idea. I'm resending my patch with this change for conveinience.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.