Re: [PATCH v2] Add global and system-wide gitattributes

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2010, 05:34 UTC
Message-ID: <7vy6bohde7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqbp8mskv1.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 22 quoted lines

> Štěpán Němec <stepnem@gmail.com> writes:
>
>> Petr Onderka <gsvick@gmail.com> writes:
>>
>>> Allow gitattributes to be set globally and system wide. This way, settings
>>> for particular file types can be set in one place and apply for all user's
>>> repositories.
>>
>> [...]
>>
>> I really can't wait till this gets into Git and I'm certainly not the
>> only one (thank you so much for working on it, Petr!).
>
> Same here ;-).
>
>> Any reason the patch still hasn't been applied?
>
> Usually, patches are applied if either
>
> 1) Junio has personal interest in it, or
>
> 2) Other people review the code and show interest for it.

(1) is a bit more subtle than that. Even when I do not foresee using a proposed feature myself, if I can imagine somebody else would benefit, and more importantly if I can see a healthy rationale behind the change so that I can convince myself to be an advocate of that change to the end users, such a change will fall into category (1). That is why I often ask people to justify their changes better than they originally do.

Isn't the patch in question on 'pu' to be tried by interested parties already?