Re: [PATCH v3?] Add global and system-wide gitattributes

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2010, 08:04 UTC
Message-ID: <7vzkw4edc5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87fwxxhfpp.fsf_-_@gmail.com>

Štěpán Němec <stepnem@gmail.com> writes:

Show 9 quoted lines

> Thanks, Matthieu!
>
> Petr's original patch doesn't apply cleanly due to a bogus context line
> after a recent change in Makefile. For convenience, below is the updated
> patch including Matthieu's changes applicable to current master.
>
> And FWIW (I didn't try to build the documentation, though):
>
> Tested-by: Štěpán Němec <stepnem@gmail.com>

Thanks, but this seems to break t8005 for whatever reason.

Show 9 quoted lines

> diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh
> index 53bd7fc..7fe3b49 100755
> --- a/t/t0003-attributes.sh
> +++ b/t/t0003-attributes.sh
> @@ -15,6 +15,7 @@ attr_check () {
>  
>  }
>  
> +HOME=$(pwd)

I see a few tests here and there that uses the test-trash directory as HOME; perhaps we should have done that in test-lib.sh to make our life easier?