Re: [PATCH 3/3 v4] Add global and system-wide gitattributes

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2010, 23:56 UTC
Message-ID: <7vfwxu8hg5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqbp8i2yns.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 10 quoted lines

> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>
>> This version doesn't touch config.c, and calls git_config with a
>> trivial callback reading only the core.attributesfile variable.
>
> I see that pu has a variant of my fix:
>
>   17cd572 fixup! Add global and system-wide gitattributes
>
> (is the fixup! here on purpose, or is it a failed rebase -i?)

It wasn't a failed "rebase -i" but was a reminder to myself. I didn't want to squash that in before discussing on the list.

> ... I'm resending my patch with this change for conveinience.

Will take a look; it will have to wait until my git Wednesday this week to be pushed out, though.

Thanks.