Re: [PATCH review] Build: make PERL_PATH = /usr/bin/env perl

From

Matthieu Moy <matthieu.moy@imag.fr>

Date

Jun 1, 2008, 08:22 UTC

Message-ID

<vpqabi5o992.fsf@bauges.imag.fr>

In-Reply-To

<1212258886-87484-1-git-send-email-mfwitten@mit.edu>

Michael Witten <mfwitten@MIT.EDU> writes:

> [problem with different versions of perl]

> It would seem to me that something like '/usr/bin/env perl' is slightly
> more vanilla in the sense that it can handle more cases.
>
> Perhaps the Makefile can be smarter about guessing the right path?

Perhaps something like this?

diff --git a/Makefile b/Makefile
index 865e2bf..5828745 100644
--- a/Makefile
+++ b/Makefile
@@ -323,7 +323,7 @@ ifndef SHELL_PATH
 	SHELL_PATH = /bin/sh
 endif
 ifndef PERL_PATH
-	PERL_PATH = /usr/bin/perl
+	PERL_PATH = $(shell which perl)
 endif
 
 export PERL_PATH

(untested)

This would generate the same files in the common case, but detect
another installation at compile time.

Note that this is indeed different from the original proposal in the
case of a multi-user system: here, the perl installation is chosen
once and for all by the guy who installs git, but can't be overridden
later (e.g by a user having his own custom perl installation in his
$HOME). I don't know which is better.

-- 
Matthieu