Re: [PATCH review] Build: make PERL_PATH = /usr/bin/env perl
- From
Michael Witten <mfwitten@mit.edu>
- Date
- Jun 1, 2008, 04:48 UTC
- Message-ID
- <8F19F8D7-A9D3-41F5-9F64-1E955BC08DF0@mit.edu>
- In-Reply-To
- <7vabi6fdun.fsf@gitster.siamese.dyndns.org>
On 31 May 2008, at 3:55 PM, Junio C Hamano wrote:
> If you insist, you can do so from your "make" command line, but I'd > prefer > the default configuration as vanilla as possible.
The main trouble I've run into is with multiple versions of perl installed. For instance, it is unadvisable to overwrite the Mac OS X provided perl distribution. Consequently, custom installations are usually put into /usr/local (also, MacPorts install everything into /opt/local).
This means that a 'vanilla' configuration may not (most likely will not) make use of the perl distribution that is actually employed by the user.
This matters, because some tools like git-send-email require extra CPAN modules such as Net::SMTP::SSL, which won't be found unless git has been configured with a custom PERL_PATH.
It would seem to me that something like '/usr/bin/env perl' is slightly more vanilla in the sense that it can handle more cases.
Perhaps the Makefile can be smarter about guessing the right path?
Sincerely, Michael Witten