Re: [PATCH review] Build: make PERL_PATH = /usr/bin/env perl

From: Junio C Hamano <gitster@pobox.com>
Date: May 31, 2008, 19:55 UTC
Message-ID: <7vabi6fdun.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1212258886-87484-1-git-send-email-mfwitten@mit.edu>

Michael Witten <mfwitten@MIT.EDU> writes:

Show 21 quoted lines

> This should make PERL_PATH more robust, as some
> systems may have multiple version of perl installed.
>
> Signed-off-by: Michael Witten <mfwitten@mit.edu>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 865e2bf..5828745 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -323,7 +323,7 @@ ifndef SHELL_PATH
>  	SHELL_PATH = /bin/sh
>  endif
>  ifndef PERL_PATH
> -	PERL_PATH = /usr/bin/perl
> +	PERL_PATH = /usr/bin/env perl
>  endif
>  
>  export PERL_PATH

If you insist, you can do so from your "make" command line, but I'd prefer the default configuration as vanilla as possible.

I notice that both git-svn.perl and git-relink.perl begin with "#!/usr/bin/env perl", and I think that is a mistake. The #! line is rewritten by Makefile, and there is no reason to write a "/usr/bin/env" ugliness there in the source. Not that it hurts, as it is blown away when Makefile rewrites it to "#!$(PERL_PATH)", but it still looks ugly.