Re: [PATCH review] Build: make PERL_PATH = /usr/bin/env perl

From: Steven Walter <stevenrwalter@gmail.com>
Date: Jun 1, 2008, 18:11 UTC
Message-ID: <e06498070806011111w792399dfi9dad780ee00faa8a@mail.gmail.com>
In-Reply-To: <1212258886-87484-1-git-send-email-mfwitten@mit.edu>

On Sat, May 31, 2008 at 2:34 PM, Michael Witten <mfwitten@mit.edu> wrote:

Show 23 quoted lines

> This should make PERL_PATH more robust, as some
> systems may have multiple version of perl installed.
>
> Signed-off-by: Michael Witten <mfwitten@mit.edu>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 865e2bf..5828745 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -323,7 +323,7 @@ ifndef SHELL_PATH
>        SHELL_PATH = /bin/sh
>  endif
>  ifndef PERL_PATH
> -       PERL_PATH = /usr/bin/perl
> +       PERL_PATH = /usr/bin/env perl
>  endif
>
>  export PERL_PATH
> --
> 1.5.5.GIT

If you do this, you will have to modify the perl scripts to remove the -w flag from their hash-bang line. "/usr/bin/env perl -w" does not seem to do the expected thing.

-- 
-Steven Walter <stevenrwalter@gmail.com>
"A human being should be able to change a diaper, plan an invasion,
butcher a hog, conn a ship, design a building, write a sonnet, balance
accounts, build a wall, set a bone, comfort the dying, take orders,
give orders, cooperate, act alone, solve equations, analyze a new
problem, pitch manure, program a computer, cook a tasty meal, fight
efficiently, die gallantly. Specialization is for insects."
 -Robert Heinlein