Re: [PATCH v6] Add a remote helper to interact with mediawiki (fetch & push)
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Here:
>>
>> + for my $refspec (@refsspecs) {
>> + unless ($refspec =~ m/^(\+?)([^:]*):([^:]*)$/) {
>> + die("Invalid refspec for push. Expected <src>:<dst> or +<src>:<dst>");
>> + }
>> + my ($force, $local, $remote) = ($1 eq "+", $2, $3);
>>
>> At this point, $force is a boolean saying whether there were a +, and
>> $local and $remote are as you can guess.
>
> It may be slightly more Perl-ish to hoist the "0-or-1" outside the group
> and rely on $1 becoming undef, like this:
>
> my ($force, $local, $remote) = $refspec =~ /^(\+)?([^:]*):([^:]*)$/
> or die(...);Thanks, I didn't know I could do this.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/