Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push)
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Aug 29, 2011, 05:42 UTC
- Message-ID
- <CAGdFq_iYRkfnTbYAgmX1g4uOxWb_ZYxr+TNinVfWRV-zXrnzAg@mail.gmail.com>
- In-Reply-To
- <7v4o14dppz.fsf@alter.siamese.dyndns.org>
Heya,
2011/8/26 Junio C Hamano <gitster@pobox.com>:
Show 10 quoted lines
> Matthieu Moy <Matthieu.Moy@imag.fr> writes: >> In short, the changes since v3 are: >> >> * Adapt to newer Git, which seem to require a "done" command at the >> end of the fast-import stream. I don't understand why this is >> needed, since fast-import is called without the --done flag by >> remote-helpers, but if I don't do this, "git fetch" doesn't >> terminate and keeps waiting ... > > Hmmmm, is this a regression in fast-import? Can this be bisected if so?
We agreed that making this change is the best way to go forward, since there's so few (read: none) remote-helpers yet, the fix is trivial, and it solves a design mistake while the api is not yet set in stone.
-- Cheers, Sverre Rabbelier