Re: done feature in remote-helpers (was Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push))

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Aug 31, 2011, 13:16 UTC
Message-ID: <CAGdFq_gooPGQMa5D19-wag=X+mDntHF1MwXiYF0zovB=L-Sybw@mail.gmail.com>
In-Reply-To: <vpq4o0xpvwy.fsf@bauges.imag.fr>

Heya,

On Wed, Aug 31, 2011 at 15:12, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 12 quoted lines

> Sverre Rabbelier <srabbelier@gmail.com> writes:
>
>> You can have multiple imports in the current system, you just need to
>> remember to add the trailing newline.
>>
>> import refs/heads/master
>> \n
>> import refs/heads/next
>> \n
>
> Then I'm lost. Isn't \n supposed to mean that the list of commands is
> over, and that the remote-helper should terminate?

No, a list of 'import' statements has to be followed by a \n, similar to the push command. You can have multiple 'blocks' of import/push commands, but each block has to be followed by a newline. Again, you should read:

import A import B \n import C import D \n

as: import A B \n import C D \n

> Also, who is "you" in your sentence? It can't be the remote helper
> (which reads this sequence), so it has to be Git's transport-helper.

Correct.

> Are you saying that the transport-helper should be modified to add \n
> after sending an import command?

As said above, it already does that. Each group of import statements is terminated with a \n.

-- 
Cheers,

Sverre Rabbelier