Re: done feature in remote-helpers (was Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push))
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Aug 31, 2011, 12:17 UTC
- Message-ID
- <CAGdFq_jyVK3_THYXzCOLDpNww0Npn2qzZ1qv-BMuLbg1vgVjZw@mail.gmail.com>
- In-Reply-To
- <vpq1uw13hx3.fsf_-_@bauges.imag.fr>
Heya,
On Wed, Aug 31, 2011 at 14:05, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 7 quoted lines
> So, is this the expected behavior? Wouldn't it be more sensible to allow > the remote-helper to issue a "done" after each "import" command? Right > now, my understanding is that after an "import" command is issued, it's > no longer possible to output anything other than fast-import stream on > stdout, and I guess it'd be more future-proof to allow closing the > fast-import with a "done", and allow any dialog between git and the > remote helper afterwards.
Wow, no that's not the intended behavior. We meant to make it exactly as you describe, after each import command you end with a done. This is (should) also be what the testgit implementation does currently, and it's what my remote-hg helper does as well. I'm not sure why it's not working for you, but if it's not then that is definitely a bug, and not intended behavior.
-- Cheers, Sverre Rabbelier