Re: [PATCH v2 00/22] Memory leak fixes (pt.9)

From: Justin Tobler <jltobler@gmail.com>
Date: Nov 4, 2024, 22:46 UTC
Message-ID: <v4cfsfnmvqhedtsoykax4wkq2ug6ke4c2rrtbwmtanmc2fonzj@4il4rzkuyffa>
In-Reply-To: <cover.1729502823.git.ps@pks.im>

On 24/10/21 11:27AM, Patrick Steinhardt wrote:

Show 16 quoted lines

> Hi,
> 
> this is the second version of my 9th series of memory leak fixes.
> 
> Changes compared to v1:
> 
>   - Split up the trailer fixes into two separate patches so that we can
>     explain them standalone.
> 
>   - Adapt the second trailer memory leak fix to instead pull up the
>     strbufs out of the loop such that we can reuse them. This makes the
>     code flow more naturally and optimizes the loop.
> 
> Thanks!
> 
> Patrick

I've reviewed all the patches in this version and left a few non-blocking thoughts. Overall, this version looks good to me though. :)

-Justin

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.