[PATCH v3 08/22] upload-pack: fix leaking URI protocols
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Nov 5, 2024, 06:17 UTC
- Message-ID
- <c5813079d44ff8959f21b7b8b19414ada475c133.1730786196.git.ps@pks.im>
- In-Reply-To
- <cover.1730786195.git.ps@pks.im>
We don't clear `struct upload_pack::uri_protocols`, which causes a memory leak. Fix this.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- t/t5702-protocol-v2.sh | 1 + upload-pack.c | 1 + 2 files changed, 2 insertions(+)
diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh index 1ef540f73d3..ed55a2f7f95 100755 --- a/t/t5702-protocol-v2.sh +++ b/t/t5702-protocol-v2.sh @@ -7,6 +7,7 @@ TEST_NO_CREATE_REPO=1 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh # Test protocol v2 with 'git://' transport diff --git a/upload-pack.c b/upload-pack.c index 6d6e0f9f980..b4a59c3518b 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -166,6 +166,7 @@ static void upload_pack_data_clear(struct upload_pack_data *data) object_array_clear(&data->extra_edge_obj); list_objects_filter_release(&data->filter_options); string_list_clear(&data->allowed_filters, 0); + string_list_clear(&data->uri_protocols, 0); free((char *)data->pack_objects_hook); }
-- 2.47.0.229.g8f8d6eee53.dirty