From: Justin Tobler <jltobler@gmail.com>
Date: Mon, 04 Nov 2024 22:46:57 GMT
Subject: Re: [PATCH v2 00/22] Memory leak fixes (pt.9)
Message-ID: <v4cfsfnmvqhedtsoykax4wkq2ug6ke4c2rrtbwmtanmc2fonzj@4il4rzkuyffa>
In-Reply-To: <cover.1729502823.git.ps@pks.im>

On 24/10/21 11:27AM, Patrick Steinhardt wrote:
> Hi,
> 
> this is the second version of my 9th series of memory leak fixes.
> 
> Changes compared to v1:
> 
>   - Split up the trailer fixes into two separate patches so that we can
>     explain them standalone.
> 
>   - Adapt the second trailer memory leak fix to instead pull up the
>     strbufs out of the loop such that we can reuse them. This makes the
>     code flow more naturally and optimizes the loop.
> 
> Thanks!
> 
> Patrick

I've reviewed all the patches in this version and left a few
non-blocking thoughts. Overall, this version looks good to me though. :)

-Justin