Re: [PATCH 06/21] diff-lib: fix leaking diffopts in `do_diff_cache()`

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 21, 2024, 09:46 UTC
Message-ID: <015d0995-c7db-45c9-9ad5-d4ea75d8f792@app.fastmail.com>
In-Reply-To: <60af98cb2c7752edc7cd5c5fe8173dc5b2522a7b.1728624670.git.ps@pks.im>

On Fri, Oct 11, 2024, at 07:32, Patrick Steinhardt wrote:

> In `do_diff_cache()` we initialize a new `rev_info` and then overwrite
> its `diffopt` with a user-provided set of options. This can leak memory
> because `repo_init_revisions()` may end up allocating memory for the
> `diffopt` itself depending on the configuration. And as that field is

s/as that/since that/

“since” communicates causality better.

> overwritten we won't ever free that.

s/free that/free it/

-- 
Kristoffer Haugsbakk

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.