Re: [PATCH 02/10] packfile: pass source to `prepare_pack()`

From: Justin Tobler <jltobler@gmail.com>
Date: Dec 15, 2025, 21:38 UTC
Message-ID: <sohvmebpsi67epmtm527grrxfl2yxljehk4masb3zfljbaffqd@szgp3mgqteyo>
In-Reply-To: <20251215-b4-pks-pack-store-via-source-v1-2-433aac465295@pks.im>

On 25/12/15 08:36AM, Patrick Steinhardt wrote:

Show 5 quoted lines

> When preparing a packfile we pass various pieces attached to the pack's
> object database source via the `struct prepare_pack_data`. Refactor this
> code to instead pass in the source directly. This reduces the number of
> variables we need to pass and allows for a subsequent refactoring where
> we start to prepare the pack via the source.

Just passing the source around is indeed simpler. This patch looks trivially correct.

-Justin

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.