Re: [PATCH 08/10] packfile: inline `find_kept_pack_entry()`

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 18, 2025, 06:48 UTC
Message-ID: <aUOj0RIyBni17_f-@pks.im>
In-Reply-To: <qoh5ew72t4pdzdfu5slsc3lqnlai5crudrixu6ohn55cuy2c5s@lzxjijg4ho3p>

On Wed, Dec 17, 2025 at 07:06:02PM -0600, Justin Tobler wrote:

Show 11 quoted lines

> On 25/12/15 08:36AM, Patrick Steinhardt wrote:
> > The `find_kept_pack_entry()` function is only used in
> > `has_oject_kept_pack()`, which is only a trivial wrapper itself. Inline
> > the latter into the former.
> > 
> > Furthermore, reorder the code so that we can drop the declaration of the
> > function in "packfile.h". This allow us to make the function file-local.
> 
> s/allow/allows/
> 
> The changes in this patch look good though.

Thanks for your review!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.