git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] [WIP] removed fetch_if_missing global

From
HGHariom Verma via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 20, 2020, 19:54 UTC
Message-ID
<pull.606.git.1587412477.gitgitgadget@gmail.com>

We are not much happy with global variable fetch_if_missing. So, in commit 6462d5eb9a ("fetch: remove fetch_if_missing=0", 2019-11-08) Jonathan Tan jonathantanmy@google.com [jonathantanmy@google.com] attempted to remove the need for fetch_if_missing=0 from the fetching mechanism. After that, fetch_if_missing is removed from clone and promisor-remote too.

I imitated the same logic to remove fetch_if_missing from fetch-pack & index-pack.

I'm looking forward to remove fetch_if_missing from other places too, but I not sure about how to handle it.

In fsck, fetch_if_missing is set to 0 in the beginning of cmd_fsck().

In rev-list, fetch_if_missing is set to 0 in parse_missing_action_value(), and in cmd_rev_list() while parsing the command-line parameters.(almost similar case in pack-objects)

fixes #251
Hariom Verma (2):
  fetch-pack: remove fetch_if_missing=0
  index-pack: remove fetch_if_missing=0
 builtin/fetch-pack.c |  2 --
 builtin/index-pack.c | 11 ++---------
 fetch-pack.c         |  2 +-
 3 files changed, 3 insertions(+), 12 deletions(-)
base-commit: be8661a3286c67a5d4088f4226cbd7f8b76544b0
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-606%2Fharry-hov%2Ffetch-if-missing-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-606/harry-hov/fetch-if-missing-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/606
-- 
gitgitgadget
Next: Hariom Verma via GitGitGadget
Message 1 of 19 in “[WIP] removed fetch_if_missing global”
  1. 0/2 [WIP] removed fetch_if_missing globalHariom Verma via GitGitGadget, Apr 20, 2020
  2. 1/2 fetch-pack: remove fetch_if_missing=0Hariom Verma via GitGitGadget, Apr 20, 2020
  3. Christian CouderMay 7, 2020
  4. Junio C HamanoMay 7, 2020
  5. Hariom vermaMay 9, 2020
  6. Hariom vermaMay 9, 2020
  7. Jonathan TanMay 7, 2020
  8. Hariom vermaMay 9, 2020
  9. Kousik SanagavarapuFeb 20, 2023
  10. Jonathan TanFeb 22, 2023
  11. Kousik SanagavarapuFeb 22, 2023
  12. 2/2 index-pack: remove fetch_if_missing=0Hariom Verma via GitGitGadget, Apr 20, 2020
  13. Christian CouderMay 7, 2020
  14. Hariom vermaMay 9, 2020
  15. Kousik SanagavarapuFeb 17, 2023
  16. Christian CouderFeb 18, 2023
  17. Kousik SanagavarapuFeb 19, 2023
  18. Christian CouderFeb 19, 2023
  19. Hariom vermaFeb 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.