Re: [PATCH 1/2] fetch-pack: remove fetch_if_missing=0

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 22, 2023, 18:19 UTC
Message-ID: <20230222181908.1177403-1-jonathantanmy@google.com>
In-Reply-To: <20230220181324.25116-1-five231003@gmail.com>

Kousik Sanagavarapu <five231003@gmail.com> writes:

> Also, is the shallow object not sent when cloning due to the partial
> clone filter and hence a subsequent fetching is done to ask for this
> object? If so, then will such a fetch counted as an args->update_shallow?

What do you mean by the shallow object? If you mean the last commit that is sent (that is, without its parents), then that is a commit and is not excluded by the filter.

As for args->update_shallow, that's a good question. Just glancing at the code, even if it is set, I don't think there would be any difference in operation since the lazy fetch does not fetch any refs (and in fact, in protocol v2, we skip the ref advertisement in this case, as far as I can remember).