Re: [PATCH 1/2] fetch-pack: remove fetch_if_missing=0

From: Christian Couder <christian.couder@gmail.com>
Date: May 7, 2020, 13:17 UTC
Message-ID: <CAP8UFD2b_27VeLFg3BrbacoJ5+GAxa+JrF3E2jS_dN-xyCRP_Q@mail.gmail.com>
In-Reply-To: <eb0cbeeeed080596c130f657186894999ae6121b.1587412477.git.gitgitgadget@gmail.com>

On Mon, Apr 20, 2020 at 9:57 PM Hariom Verma via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 7 quoted lines

>
> From: Hariom Verma <hariom18599@gmail.com>
>
> Commit 6462d5e ("fetch: remove fetch_if_missing=0", 2019-11-08)
> strove to remove the need for fetch_if_missing=0 from the fetching
> mechanism, so it is plausible to attempt removing fetch_if_missing=0
> from fetch-pack as well.

It's ok to refer to a previous commit, but I think it would be better if you could repeat a bit the reasons why removing the fetch_if_missing global is a good idea, and not just rely on the previous commit.

"it is plausible" also doesn't make it very clear that it's what the patch is actually doing.

Thanks, Christian.