Re: [PATCH 1/2] fetch-pack: remove fetch_if_missing=0

From

Hariom verma <hariom18599@gmail.com>

Date

May 9, 2020, 17:40 UTC

Message-ID

<CA+CkUQ8WYd+sR6cBKxK73SJZR-yFnea6Gz+pNABSso44Sgv6Pg@mail.gmail.com>

In-Reply-To

<CAP8UFD2b_27VeLFg3BrbacoJ5+GAxa+JrF3E2jS_dN-xyCRP_Q@mail.gmail.com>

>
> It's ok to refer to a previous commit, but I think it would be better
> if you could repeat a bit the reasons why removing the
> fetch_if_missing global is a good idea, and not just rely on the
> previous commit.

I agree with that.

> "it is plausible" also doesn't make it very clear that it's what the
> patch is actually doing.

Thanks for pointing it out. Will improve.