git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] mingw: stop using nedmalloc

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 3, 2026, 12:29 UTC
Message-ID
<pull.2104.git.1777811392756.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

The vendored nedmalloc allocator under compat/nedmalloc/ has been unmaintained upstream for a very long time: the original repository at https://github.com/ned14/nedmalloc received its last commit on July 5, 2014, and was archived (made read-only) by its owner on March 15, 2019. Our copy has been carried forward unchanged ever since.

The Git for Windows commit that introduced mimalloc as a replacement on Windows ("mingw: use mimalloc", 2019-06-24, present in the Git for Windows branch thicket but not upstream) already observed at that time that nedmalloc had ceased to see any updates for several years.

This came to a head when the Git for Windows SDK upgraded to GCC 16: the `add_segment()` function in `compat/nedmalloc/malloc.c.h` declares `int nfences = 0` and only references it inside an `assert()`, which GCC 16 now flags as `-Wunused-but-set-variable`. Combined with the `-Werror` enabled by `DEVELOPER=1`, this turns into a hard build failure:

	compat/nedmalloc/malloc.c.h: In function 'add_segment':
	compat/nedmalloc/malloc.c.h:3897:7: error: variable 'nfences' set but not used [-Werror=unused-but-set-variable=]
	 3897 |   int nfences = 0;
	      |       ^~~~~~~
	cc1.exe: all warnings being treated as errors

The same source built without complaint under GCC 15.2.0; the regression was bisected to the SDK package update at https://github.com/git-for-windows/git-sdk-64/commit/188d93dd455 (`mingw-w64-x86_64-gcc 15.2.0-14 -> 16.1.0-1`), with the failing CI run captured at https://github.com/git-for-windows/git-sdk-64/actions/runs/25244795074.

Rather than patch the unmaintained vendored sources to silence the warning, stop opting into nedmalloc altogether on MINGW. The platform allocator is what every non-MINGW build already uses, and a fresh build of git.git's master against a minimal Git for Windows SDK upgraded to GCC 16, with `USE_NED_ALLOCATOR` removed from the MINGW section, completes successfully.

The compat/nedmalloc/ subtree itself is left in place to keep this change minimal; nothing in the build links against it any longer, so it can be removed in a follow-up if desired.

Assisted-by: Claude Opus 4.7
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    mingw: stop using nedmalloc
    
    Git for Windows' SDK wants to update GCC to v16. Since it is used in the
    CI builds also of the git/git repository, it is crucial that GCC can
    compile even the latter all right, but currently it does not, see
    https://github.com/git-for-windows/git-sdk-64/actions/runs/25244795074.
    
    Git for Windows switched away from nedmalloc to mimalloc a long time
    ago, anyway. I plan on upstreaming this soon-ish, after this here patch
    lands.
    
    Note that with this patch, I reverse the order I indicated in
    https://lore.kernel.org/git/00fd3145-b3d2-ddab-466d-d06fd27298ec@gmx.de/:
    I first disable nedmalloc for MINGW builds (and possibly drop the
    vendored-in nedmalloc from Git's source code). The reason is that I am
    still trying to figure out the best way to integrate mimalloc:
    https://github.com/git-for-windows/git/commit/d67535b61dd (Import the
    source code of mimalloc v2.2.7, 2026-01-16) in patch form would weigh
    some ~700kB, which would not only be rejected by the Git mailing list,
    but which I myself would reject if I was the Git maintainer merely on
    the basis of the sheer size of the patch. Probably the best course of
    action is to add support for a non-vendored-in mimalloc first, then keep
    the vendored-in copy in Git for Windows (where no mailing list stands in
    the way of large patches). Whatever it will be, it's best to fast-track
    this here patch to disable nedmalloc for Windows builds, so that the CI
    builds can switch to using GCC 16 (and the current Git for Windows SDK)
    on Windows.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2104%2Fdscho%2Fstop-using-nedmalloc-with-mingw-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2104/dscho/stop-using-nedmalloc-with-mingw-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2104
 config.mak.uname | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/config.mak.uname b/config.mak.uname
index 5feb582558..3636b98238 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -758,9 +758,6 @@ ifeq ($(uname_S),MINGW)
 	HAVE_LIBCHARSET_H = YesPlease
 	USE_GETTEXT_SCHEME = fallthrough
 	USE_LIBPCRE = YesPlease
-        ifneq (CLANGARM64,$(MSYSTEM))
-		USE_NED_ALLOCATOR = YesPlease
-        endif
         ifeq (/mingw64,$(subst 32,64,$(subst clangarm,mingw,$(prefix))))
 		# Move system config into top-level /etc/
 		ETC_GITCONFIG = ../etc/gitconfig

base-commit: 94f057755b7941b321fd11fec1b2e3ca5313a4e0
-- 
gitgitgadget
Next: Patrick Steinhardt
Message 1 of 20 in “mingw: stop using nedmalloc”
  1. mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 3, 2026
  2. Patrick SteinhardtMay 5, 2026
  3. 0/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  4. 1/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  5. 2/6 mingw: drop the build-system plumbing for nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  6. 3/6 mingw: drop the small nedmalloc auxiliary filesJohannes Schindelin via GitGitGadget, May 7, 2026
  7. 4/6 mingw: drop the first chunk of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  8. 5/6 mingw: drop the second chunk of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  9. 6/6 mingw: drop the rest of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  10. Junio C HamanoMay 8, 2026
  11. Jeff KingMay 8, 2026
  12. 0/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  13. 1/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  14. 2/6 mingw: drop the build-system plumbing for nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  15. 3/6 mingw: remove the vendored compat/nedmalloc/ subtreeJohannes Schindelin via GitGitGadget, May 8, 2026
  16. 5/6 to be squashed into 3/6 (chunk 2 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  17. 4/6 to be squashed into 3/6 (chunk 1 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  18. 6/6 to be squashed into 3/6 (chunk 3 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  19. Patrick SteinhardtMay 8, 2026
  20. Junio C HamanoMay 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.