git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/6] mingw: drop the build-system plumbing for nedmalloc

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 7, 2026, 16:00 UTC
Message-ID
<7b5daae659f491ce8a2ba52d02ba7172106120d8.1778169613.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2104.v2.git.1778169613.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

With the previous commit removing every opt-in, the build-system plumbing for nedmalloc has nothing left to switch on. Remove it so that the upcoming deletion of the compat/nedmalloc/ tree is a pure file removal.

Assisted-by: Opus 4.7
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 Makefile               | 17 -----------------
 config.mak.uname       |  1 -
 contrib/vscode/init.sh |  1 -
 meson.build            |  1 -
 4 files changed, 20 deletions(-)
diff --git a/Makefile b/Makefile
index cedc234173..2f490d402e 100644
--- a/Makefile
+++ b/Makefile
@@ -283,13 +283,9 @@ include shared.mak
 # Define SKIP_DASHED_BUILT_INS if you do not need the dashed versions of the
 # built-ins to be linked/copied at all.
 #
-# Define USE_NED_ALLOCATOR if you want to replace the platforms default
-# memory allocators with the nedmalloc allocator written by Niall Douglas.
-#
 # Define OVERRIDE_STRDUP to override the libc version of strdup(3).
 # This is necessary when using a custom allocator in order to avoid
 # crashes due to allocation and free working on different 'heaps'.
-# It's defined automatically if USE_NED_ALLOCATOR is set.
 #
 # Define NO_REGEX if your C library lacks regex support with REG_STARTEND
 # feature.
@@ -1511,7 +1507,6 @@ BUILTIN_OBJS += builtin/write-tree.o
 # upstream unnecessarily (making merging in future changes easier).
 THIRD_PARTY_SOURCES += compat/inet_ntop.c
 THIRD_PARTY_SOURCES += compat/inet_pton.c
-THIRD_PARTY_SOURCES += compat/nedmalloc/%
 THIRD_PARTY_SOURCES += compat/obstack.%
 THIRD_PARTY_SOURCES += compat/poll/%
 THIRD_PARTY_SOURCES += compat/regex/%
@@ -2267,12 +2262,6 @@ ifdef NATIVE_CRLF
 	BASIC_CFLAGS += -DNATIVE_CRLF
 endif
 
-ifdef USE_NED_ALLOCATOR
-	COMPAT_CFLAGS += -Icompat/nedmalloc
-	COMPAT_OBJS += compat/nedmalloc/nedmalloc.o
-	OVERRIDE_STRDUP = YesPlease
-endif
-
 ifdef OVERRIDE_STRDUP
 	COMPAT_CFLAGS += -DOVERRIDE_STRDUP
 	COMPAT_OBJS += compat/strdup.o
@@ -2983,12 +2972,6 @@ compat/regex/regex.sp compat/regex/regex.o: EXTRA_CPPFLAGS = \
 	-DGAWK -DNO_MBSUPPORT
 endif
 
-ifdef USE_NED_ALLOCATOR
-compat/nedmalloc/nedmalloc.sp compat/nedmalloc/nedmalloc.o: EXTRA_CPPFLAGS = \
-	-DNDEBUG -DREPLACE_SYSTEM_ALLOCATOR
-compat/nedmalloc/nedmalloc.sp: SP_EXTRA_FLAGS += -Wno-non-pointer-null
-endif
-
 headless-git.o: compat/win32/headless.c GIT-CFLAGS
 	$(QUIET_CC)$(CC) $(ALL_CFLAGS) $(COMPAT_CFLAGS) \
 		-fno-stack-protector -o $@ -c -Wall -Wwrite-strings $<
diff --git a/config.mak.uname b/config.mak.uname
index 3636b98238..25345e02c6 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -491,7 +491,6 @@ ifeq ($(uname_S),Windows)
 	USE_WIN32_IPC = YesPlease
 	USE_WIN32_MMAP = YesPlease
 	MMAP_PREVENTS_DELETE = UnfortunatelyYes
-	# USE_NED_ALLOCATOR = YesPlease
 	UNRELIABLE_FSTAT = UnfortunatelyYes
 	OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
 	NO_REGEX = YesPlease
diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
index f2d61bb0e6..3d58f7307a 100755
--- a/contrib/vscode/init.sh
+++ b/contrib/vscode/init.sh
@@ -202,7 +202,6 @@ cat >.vscode/settings.json.new <<\EOF ||
         "\\bUSE_STDEV\\b",
         "\\Wchar *\\*\\W*utfs\\W",
         "cURL's",
-        "nedmalloc'ed",
         "ntifs\\.h",
     ],
 }
diff --git a/meson.build b/meson.build
index e896bc15a1..0e00c6c57e 100644
--- a/meson.build
+++ b/meson.build
@@ -698,7 +698,6 @@ third_party_excludes = [
   ':!contrib',
   ':!compat/inet_ntop.c',
   ':!compat/inet_pton.c',
-  ':!compat/nedmalloc',
   ':!compat/obstack.*',
   ':!compat/poll',
   ':!compat/regex',
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 5 of 20 in “mingw: stop using nedmalloc”
  1. mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 3, 2026
  2. Patrick SteinhardtMay 5, 2026
  3. 0/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  4. 1/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  5. 2/6 mingw: drop the build-system plumbing for nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  6. 3/6 mingw: drop the small nedmalloc auxiliary filesJohannes Schindelin via GitGitGadget, May 7, 2026
  7. 4/6 mingw: drop the first chunk of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  8. 5/6 mingw: drop the second chunk of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  9. 6/6 mingw: drop the rest of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  10. Junio C HamanoMay 8, 2026
  11. Jeff KingMay 8, 2026
  12. 0/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  13. 1/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  14. 2/6 mingw: drop the build-system plumbing for nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  15. 3/6 mingw: remove the vendored compat/nedmalloc/ subtreeJohannes Schindelin via GitGitGadget, May 8, 2026
  16. 5/6 to be squashed into 3/6 (chunk 2 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  17. 4/6 to be squashed into 3/6 (chunk 1 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  18. 6/6 to be squashed into 3/6 (chunk 3 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  19. Patrick SteinhardtMay 8, 2026
  20. Junio C HamanoMay 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.