git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/6] mingw: stop using nedmalloc

From
Patrick Steinhardt <ps@pks.im>
Date
May 8, 2026, 13:17 UTC
Message-ID
<af3ieN6WRsQSZ5rj@pks.im>
In-Reply-To
<pull.2104.v3.git.1778244661.gitgitgadget@gmail.com>
On Fri, May 08, 2026 at 12:50:55PM +0000, Johannes Schindelin via GitGitGadget wrote:
Show 32 quoted lines
> Git for Windows' SDK wants to update GCC to v16. Since it is used in the CI
> builds also of the git/git repository, it is crucial that GCC can compile
> even the latter all right, but currently it does not, see
> https://github.com/git-for-windows/git-sdk-64/actions/runs/25244795074.
> 
> Git for Windows switched away from nedmalloc to mimalloc a long time ago,
> but recent benchmarks across Windows, macOS, and Linux (see
> https://github.com/git-for-windows/git/pull/6231) show no measurable benefit
> from mimalloc over the platforms' default allocators, so rather than
> upstreaming the mimalloc support, I will drop it from Git for Windows
> entirely.
> 
> This series therefore disables nedmalloc for MINGW builds and removes the
> vendored-in nedmalloc from Git's source code; my earlier sketch in
> https://lore.kernel.org/git/00fd3145-b3d2-ddab-466d-d06fd27298ec@gmx.de/ had
> the opposite ordering only because it assumed mimalloc would land first.
> Since that's not going to happen, it's best to move forward with this, so
> that the CI builds can switch to using GCC 16 (and the current Git for
> Windows SDK) on Windows.
> 
> The patches that remove the vendored sources have a slightly unusual shape:
> the Git mailing list rejects messages over 100kB and
> compat/nedmalloc/malloc.c.h alone is ~196kB of source, so the deletion of
> that file is split at section boundaries into three commits, each
> comfortably under the cap. The intention (as documented by the last three
> commit messages) is for them to be squashed by the Git maintainer before
> merging.
> 
> Changes since v2:
> 
>  * Reworded the last 4 patches as recommended by Junio, in preparation for
>    squashing them on his end.
Heh, fun.
Show 6 quoted lines
> Changes since v1:
> 
>  * Also remove nedmalloc from the CMake and Meson configurations in the
>    first patch.
>  * Add follow-up patches that drop the nedmalloc build-system plumbing and
>    source files.

I think removing nedmalloc makes sense, and am happy with the state of this series. Thanks!

Patrick
Previous: Johannes Schindelin via GitGitGadgetNext: Junio C Hamano
Message 19 of 20 in “mingw: stop using nedmalloc”
  1. mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 3, 2026
  2. Patrick SteinhardtMay 5, 2026
  3. 0/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  4. 1/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  5. 2/6 mingw: drop the build-system plumbing for nedmallocJohannes Schindelin via GitGitGadget, May 7, 2026
  6. 3/6 mingw: drop the small nedmalloc auxiliary filesJohannes Schindelin via GitGitGadget, May 7, 2026
  7. 4/6 mingw: drop the first chunk of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  8. 5/6 mingw: drop the second chunk of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  9. 6/6 mingw: drop the rest of compat/nedmalloc/malloc.c.hJohannes Schindelin via GitGitGadget, May 7, 2026
  10. Junio C HamanoMay 8, 2026
  11. Jeff KingMay 8, 2026
  12. 0/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  13. 1/6 mingw: stop using nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  14. 2/6 mingw: drop the build-system plumbing for nedmallocJohannes Schindelin via GitGitGadget, May 8, 2026
  15. 3/6 mingw: remove the vendored compat/nedmalloc/ subtreeJohannes Schindelin via GitGitGadget, May 8, 2026
  16. 5/6 to be squashed into 3/6 (chunk 2 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  17. 4/6 to be squashed into 3/6 (chunk 1 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  18. 6/6 to be squashed into 3/6 (chunk 3 of 3)Johannes Schindelin via GitGitGadget, May 8, 2026
  19. Patrick SteinhardtMay 8, 2026
  20. Junio C HamanoMay 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.