Re: [PATCH] mingw: stop using nedmalloc
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 5, 2026, 06:09 UTC
- Message-ID
- <afmJnZXeWtNEru4q@pks.im>
- In-Reply-To
- <pull.2104.git.1777811392756.gitgitgadget@gmail.com>
On Sun, May 03, 2026 at 12:29:52PM +0000, Johannes Schindelin via GitGitGadget wrote:
Show 11 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > Rather than patch the unmaintained vendored sources to silence the > warning, stop opting into nedmalloc altogether on MINGW. The platform > allocator is what every non-MINGW build already uses, and a fresh > build of git.git's master against a minimal Git for Windows SDK > upgraded to GCC 16, with `USE_NED_ALLOCATOR` removed from the MINGW > section, completes successfully. > > The compat/nedmalloc/ subtree itself is left in place to keep this > change minimal; nothing in the build links against it any longer, so > it can be removed in a follow-up if desired.
I guess this is fair as an intermediate step. But seeing that this removes the last user per our "config.mak.uname" I do wonder whether we want to maybe drop nedmalloc completely. Not necessarily in this patch, but maybe in a subsequent step?
Thanks!
Patrick