[PATCH v2 16/22] run-command.c: make "struct parallel_processes" const if possible
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Oct 12, 2022, 09:01 UTC
- Message-ID
- <patch-v2-16.22-acac50cc1a5-20221012T084850Z-avarab@gmail.com>
- In-Reply-To
- <cover-v2-00.22-00000000000-20221012T084850Z-avarab@gmail.com>
Add a "const" to two "struct parallel_processes" parameters where we're not modifying anything in "pp". For kill_children() we'll call it from both the signal handler, and from run_processes_parallel() itself. Adding a "const" there makes it clear that we don't need to modify any state when killing our children.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- run-command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/run-command.c b/run-command.c index 64fa0299175..6c343b9b77b 100644 --- a/run-command.c +++ b/run-command.c @@ -1538,7 +1538,7 @@ static int default_task_finished(int result, return 0; } -static void kill_children(struct parallel_processes *pp, int signo) +static void kill_children(const struct parallel_processes *pp, int signo) { for (size_t i = 0; i < pp->max_processes; i++) if (pp->children[i].state == GIT_CP_WORKING) @@ -1694,7 +1694,7 @@ static void pp_buffer_stderr(struct parallel_processes *pp, int output_timeout) } } -static void pp_output(struct parallel_processes *pp) +static void pp_output(const struct parallel_processes *pp) { size_t i = pp->output_owner;
-- 2.38.0.971.ge79ff6d20e7