Re: [PATCH v2 13/22] run-command API: make run_process_parallel{,_tr2}() thin wrappers
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Oct 12, 2022, 13:23 UTC
- Message-ID
- <9b5346b6-157e-b323-1d49-19322793d05d@gmail.com>
- In-Reply-To
- <patch-v2-13.22-01e894bed90-20221012T084850Z-avarab@gmail.com>
On 12/10/2022 10:01, Ævar Arnfjörð Bjarmason wrote:
Show 9 quoted lines
> - const struct run_process_parallel_opts opts = {
> - .processes = processes,
> -
> - .get_next_task = get_next_task,
> - .start_failure = start_failure,
> - .task_finished = task_finished,
> -
> - .ungroup = run_processes_parallel_ungroup,
> - };[...]
Show 11 quoted lines
> + const struct run_process_parallel_opts opts = {
> + .processes = processes,
> + .ungroup = run_processes_parallel_ungroup,
> +
> + .get_next_task = get_next_task,
> + .start_failure = start_failure,
> + .task_finished = task_finished,
> + };
> +
> + run_processes_parallel_1(&opts, pp_cb);
> }I complained before that this is moving things around that you added in the last commit, but not only are you moving the designated initializer added in the last commit you are rearranging it.
Best Wishes
Phillip