[PATCH v2 07/22] run-command.c: remove dead assignment in while-loop
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Oct 12, 2022, 09:01 UTC
- Message-ID
- <patch-v2-07.22-b90961ae76d-20221012T084850Z-avarab@gmail.com>
- In-Reply-To
- <cover-v2-00.22-00000000000-20221012T084850Z-avarab@gmail.com>
Remove code that's been unused since it was added in c553c72eed6 (run-command: add an asynchronous parallel child processor, 2015-12-15), the next use of "i" in this function is:
for (i = 0; ...
So we'll always clobber the "i" that's set here. Presumably the "i" assignment is an artifact of WIP code that made it into our tree.
A subsequent commit will need to adjust the type of the "i" variable in the otherwise unrelated for-loop, which is why this is being removed now.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- run-command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/run-command.c b/run-command.c index 642e6b6e057..bd45828fe2c 100644 --- a/run-command.c +++ b/run-command.c @@ -1689,7 +1689,7 @@ static void pp_buffer_stderr(struct parallel_processes *pp, int output_timeout) { int i; - while ((i = poll(pp->pfd, pp->max_processes, output_timeout)) < 0) { + while (poll(pp->pfd, pp->max_processes, output_timeout) < 0) { if (errno == EINTR) continue; pp_cleanup(pp);
-- 2.38.0.971.ge79ff6d20e7