Re: [patch 12/16] host-OSF1.patch
- From
- Tor Arntsen <tor@spacetec.no>
- Date
- Apr 27, 2010, 14:48 UTC
- Message-ID
- <p2rd2d39d861004270748q57802106gdd394cba68ce5ae7@mail.gmail.com>
- In-Reply-To
- <20100427143912.GB36271@thor.il.thewrittenword.com>
On Tue, Apr 27, 2010 at 16:39, Gary V. Vaughan <git@mlists.thewrittenword.com> wrote:
> On Tue, Apr 27, 2010 at 04:10:56PM +0200, Tor Arntsen wrote:
Show 11 quoted lines
>> but (ref. a patch I sent earlier, in its >> first revision) I needed several other changes in order to compile on >> 5.1 (I also needed those you have above), e.g. >> -D_POSIX_C_SOURCE=1 NO_STRCASESTR = YesPlease NO_STRTOUMAX = YesPlease >> NO_STRLCPY = YesPlease NO_MEMMEM = YesPlease NO_UINTMAX_T = YesPlease >> NO_C99_FORMAT = YesPlease >> and >> NO_TCLTK = YesPlease > > Indeed, I don't mean to imply that this patch is all that is needed > for OSF1, merely that the changes it contains benefit only OSF1.
I see. In that case, as I have verified that those changes are indeed necessary for OSF1:
Acked-by: Tor Arntsen <tor@spacetec.no>
> Please bear in mind that I build using configure, and may have missed > something necessary for a make-only driven build.
Ah, Ok, that would explain it. I too found that with ./configure fewer changes were needed. The patch I was working on I tested both with and without configure. If your patch goes in I could follow up with the changes needed for when not using configure, if you don't wish to tacke that.
Show 12 quoted lines
>> because V5.1 comes with tcl/tk 8.2 and gitk refuses to start with >> anything older than 8.4. >> I had some other too, but those could be worked around by building and >> installing own versions of iconv, openssl, zlib, python, expat. > > Ack. And since that is our business, we do indeed build git against > our own packages of relatively cutting edge releases of prerequisite > OS software on all our hosts (including all of the above). > > Cheers, > -- > Gary V. Vaughan (gary@thewrittenword.com)
-Tor