Re: [patch 00/16] Portability Patches for git-1.7.1 (v4)
- From
- Gary V. Vaughan <git@mlists.thewrittenword.com>
- Date
- May 3, 2010, 01:48 UTC
- Message-ID
- <20100503014834.GC1550@thor.il.thewrittenword.com>
- In-Reply-To
- <7vk4rn2oiv.fsf@alter.siamese.dyndns.org>
Hi Michael,
Thanks for putting up a public repo of those patches; much appreciated.
On Sat, May 01, 2010 at 04:25:12PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Michael J Gruber <git@drmicha.warpmail.net> writes: > > Gary V. Vaughan venit, vidit, dixit 27.04.2010 15:57: > > > Here are the portability patches we needed at TWW to enable git-1.7.1 > > > to compile and run on all of the wide range of Unix machines we > > > support. [[...]] > > > > OK, unsurprsingly, tests still pass on Linux (Fedora 12 x86_64). > > If anyone wants to try, the series can be found at > > > > git://repo.or.cz/git/mjg.git > > > > in branch > > > > gvv/platform-compatibility > > > > applied cleanly on current master. > > Thanks.
Hi Junio,
Show 6 quoted lines
> Like everybody else, I like the s/diff/test_cmp/ one in general. On > platforms without "diff -u", test_cmp may want to use "diff -c" instead > for readability, but that can be fixed/enhanced independently. > > I agree with your general remark and also noticed that the titles are way > suboptimal.
I think this is my first patch series submission to the git list, but in any case I just used used the patch file-names as is my habit for locally maintained patchsets.
Thanks for suggesting better title, which I've already adopted into my local tree. If upstream integration stalls, or if it will help smooth integration, I'll make the merging and reordering adjustments you request and resubmit the whole queue.
Cheers,
-- Gary V. Vaughan (gary@thewrittenword.com)