Re: [patch 00/16] Portability Patches for git-1.7.1 (v4)
- From
Jeff King <peff@peff.net>
- Date
- Apr 28, 2010, 02:08 UTC
- Message-ID
- <20100428020816.GC16107@coredump.intra.peff.net>
- In-Reply-To
- <m2iq7cejsh.fsf@igel.home>
On Tue, Apr 27, 2010 at 10:13:02PM +0200, Andreas Schwab wrote:
Show 9 quoted lines
> Jeff King <peff@peff.net> writes: > > > Furthermore, if we do take such changes, how are we going to manage > > portability going forward? Some constructs (like non-constant > > initializers) make the code much easier to read. People _will_ submit > > patches that use them. Is somebody going to be auto-building on all of > > these platforms with vendor compilers to confirm that nothing is broken? > > You can use "gcc -pedantic" to find these portability problems.
Sort of. It reports much more than we necessarily need to fix to remain portable to even remotely sane platforms. So it's a nice tool for finding problems, but somebody needs to do the work of figuring out which are important and which are not, and then periodically run with -pedantic and sort out the results.
-Peff