Re: [patch 06/16] diff-test_cmp.patch

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 28, 2010, 09:51 UTC
Message-ID: <20100428095159.GD1394@progeny.tock>
In-Reply-To: <20100428090045.GD36271@thor.il.thewrittenword.com>

Gary V. Vaughan wrote:

> Can I add a Sign-off message to each patch subthread?  Or do you need
> me to resubmit the entire series?

I think one sign-off for the whole series would be good enough; then the person applying the patches can forge your signed-off-by lines.

I pointed it out mostly for future patches.

> On Tue, Apr 27, 2010 at 12:15:52PM -0500, Jonathan Nieder wrote:

Show 5 quoted lines

>> And is it possible to change your mailing script to use more
>> meaningful subject lines?
>
> Sure.  What is preferable?  As short a sentence summarising the fixed
> issue as I can muster?

Yep. :) It need not be a sentence (and should skip the full stop). You can see some example subject lines by looking at the "shortlog" from git or Linux release announcements or running git log --oneline --no-merges.

Something like “tests: Use test_cmp when appropriate” would do.

Show 6 quoted lines

> (Like SuSE Linux, we use quilt to manage and
> submit our patch stacks... git seems to require hosting the entire
> history of each project which is too heavyweight for the 1000's of
> packages we build - if git provides the means to store just the head
> of an upstream release branch along with our patch stacks on local
> disk, I would love to be proven wrong here).

The most general way:

 curl http://address/of/tarball.tar.gz | tar -xf - 
 git init *
 cd *
 git add .
 git commit -m "upstream release"
 ... use git like normal

You can automate some of those steps by

 wget http://address/of/tarball.tar.gz
 git init project
 cd project
 perl /usr/share/doc/git/contrib/fast-import/import-tars.perl tarball.tar.gz
 git checkout import-tars
 ... use git as usual

If upstream uses git, there is also the shallow-clone facility:

 git clone -b master --depth=1 git://repo.or.cz/git.git/
 cd git
 ... use git as usual, except history is cauterized

It has one rough edge you may run into: push is not supported. If that is a problem for you, let me know and maybe I can try to help fix it.

Honestly, I’m okay with quilt, too. The main difference I notice is that ‘git diff’ uses the equivalent of the diff -p (--show-c-function) option by default.

> Maybe in combination with the missing Signed-off-by: headers and
> unsuitable Subject headers I need to amend and resubmit the whole
> patch series again?

I think the cognitive load on reviewers is lighter if you send small, isolated changes until you think it is as ready as it is going to get for the current round, and only then resubmit the series.

Thanks for the hard work. Jonathan