Re: [PATCH 0/2] Integrate Scalar into the CI builds
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 13, 2022, 21:03 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2206132246010.353@tvgsbejvaqbjf.bet>
- In-Reply-To
- <pull.1129.git.1654160735.gitgitgadget@gmail.com>
Hi,
On Thu, 2 Jun 2022, Johannes Schindelin via GitGitGadget wrote:
Show 16 quoted lines
> During the review of the initial Scalar patch series, it was suggested to > include Scalar in Git's CI builds. Due to some conflicts, this was postponed > to a later patch series: This patch series. > > Note that the changes to the GitHub workflow are somewhat transient in > nature: Based on the feedback I received on the Git mailing list, I see some > appetite for turning Scalar into a full-fledged top-level command in Git, > similar to gitk. Therefore my current plan is to do exactly that in the end > (and I already have patches lined up to that end). This will essentially > revert the ci/run-build-and-tests.sh change in this patch series. > > This patch series is based on js/scalar-diagnose. > > Johannes Schindelin (2): > cmake: optionally build `scalar`, too > ci: also run the `scalar` tests
Upon further reflection, I would like to retract these patches for now. They do seem a poor fit within the Scalar story arc: in the end, they won't be needed anyway (after moving Scalar out of `contrib/`).
I talked to Victoria and she kindly agreed to drive the Scalar upstreaming from here (after v2.37.0, I imagine).
Thanks, Dscho