Re: [PATCH 0/2] Integrate Scalar into the CI builds

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jun 2, 2022, 14:13 UTC
Message-ID: <220602.865yljywtf.gmgdl@evledraar.gmail.com>
In-Reply-To: <d0448d28-b33c-3f42-901d-3cd7f4201c78@github.com>

On Thu, Jun 02 2022, Derrick Stolee wrote:

Show 10 quoted lines

> On 6/2/2022 5:05 AM, Johannes Schindelin via GitGitGadget wrote:
>> Note that the changes to the GitHub workflow are somewhat transient in
>> nature: Based on the feedback I received on the Git mailing list, I see some
>> appetite for turning Scalar into a full-fledged top-level command in Git,
>> similar to gitk. Therefore my current plan is to do exactly that in the end
>> (and I already have patches lined up to that end). This will essentially
>> revert the ci/run-build-and-tests.sh change in this patch series.
>
> I expect that this won't be a full remote, since we will still want to
> exclude Scalar from the build without INCLUDE_SCALAR enabled.

"a full remote"?

Scalar (well, scalar.o, not scalar the binary) has been included in the default build (including CI) for a while now.

What we haven't been doing until this series it to link it with libgit.a or running its tests.

So perhaps that's what you mean, but in an earlier series it wasn't building scalar.o, and I remember there being some confusion on this point in the past, seemingly based on a mental model of the scalar patches that pre-dated the re-roll that eventually got merged.