git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Integrate Scalar into the CI builds

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 3, 2022, 10:04 UTC
Message-ID
<nycvar.QRO.7.76.6.2206031147220.349@tvgsbejvaqbjf.bet>
In-Reply-To
<d59b51fb-029f-8232-9dd8-2f7f1b410aa7@github.com>
Hi Stolee,
On Thu, 2 Jun 2022, Derrick Stolee wrote:
Show 14 quoted lines
> On 6/2/2022 10:13 AM, Ævar Arnfjörð Bjarmason wrote:
> >
> > On Thu, Jun 02 2022, Derrick Stolee wrote:
> >
> >> On 6/2/2022 5:05 AM, Johannes Schindelin via GitGitGadget wrote:
> >>> Note that the changes to the GitHub workflow are somewhat transient in
> >>> nature: Based on the feedback I received on the Git mailing list, I see some
> >>> appetite for turning Scalar into a full-fledged top-level command in Git,
> >>> similar to gitk. Therefore my current plan is to do exactly that in the end
> >>> (and I already have patches lined up to that end). This will essentially
> >>> revert the ci/run-build-and-tests.sh change in this patch series.
> >>
> >> I expect that this won't be a full remote, since we will still want to
> >> exclude Scalar from the build without INCLUDE_SCALAR enabled.

We had this `INCLUDE_SCALAR` condition in microsoft/git for a while but since I got the sense that many regulars were in favor of treating `scalar` like a top-level command (similar to `gitk`), I've since changed the over-all course to compiling it unconditionally.

The only remnant is the CMake definition, and only in the transitory phase while Scalar is still in `contrib/scalar/`, and only because I could not find a better way to encapsulate it.

But yes, if we decide to go with the `INCLUDE_SCALAR` approach, it won't be a full remove/revert.

Show 5 quoted lines
> > Scalar (well, scalar.o, not scalar the binary) has been included in the
> > default build (including CI) for a while now.
>
> I'm talking about scalar the binary being important. I'm glad that
> scalar.o has been built already.

These are the raw logs of the `linux-gcc` job of the most recent CI build of `seen`, as of time of writing:

https://github.com/git/git/commit/7f1978ce8bfe41074df4fc96ff7f2a28e5807fd1/checks/6718714644/logs

When I download those logs and then let my browser search for the term "scalar", it comes up empty, even if, say, "range-diff.o" is found. Which is exactly according to my plan: no part of Scalar is to be built unless explicitly asked for.

The only job that touches it is the `static-analysis` job, which is a bit unfortunate. But I cannot justify the complexity of the patch it would take to address that.

In other words: The statement that `scalar.o` is included in the default build, without any qualifying note about `static-analysis`, is quite misleading.

Ciao, Dscho

Previous: Derrick StoleeNext: Ævar Arnfjörð Bjarmason
Message 11 of 14 in “Integrate Scalar into the CI builds”
  1. 0/2 Integrate Scalar into the CI buildsJohannes Schindelin via GitGitGadget, Jun 2, 2022
  2. 1/2 cmake: optionally build `scalar`, tooJohannes Schindelin via GitGitGadget, Jun 2, 2022
  3. Ævar Arnfjörð BjarmasonJun 2, 2022
  4. 2/2 ci: also run the `scalar` testsJohannes Schindelin via GitGitGadget, Jun 2, 2022
  5. Ævar Arnfjörð BjarmasonJun 2, 2022
  6. Derrick StoleeJun 2, 2022
  7. Johannes SchindelinJun 3, 2022
  8. Derrick StoleeJun 2, 2022
  9. Ævar Arnfjörð BjarmasonJun 2, 2022
  10. Derrick StoleeJun 2, 2022
  11. Johannes SchindelinJun 3, 2022
  12. Ævar Arnfjörð BjarmasonJun 3, 2022
  13. Johannes SchindelinJun 13, 2022
  14. Ævar Arnfjörð BjarmasonJun 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.