git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Integrate Scalar into the CI builds

From
Derrick Stolee <derrickstolee@github.com>
Date
Jun 2, 2022, 14:00 UTC
Message-ID
<d0448d28-b33c-3f42-901d-3cd7f4201c78@github.com>
In-Reply-To
<pull.1129.git.1654160735.gitgitgadget@gmail.com>
On 6/2/2022 5:05 AM, Johannes Schindelin via GitGitGadget wrote:
> During the review of the initial Scalar patch series, it was suggested to
> include Scalar in Git's CI builds. Due to some conflicts, this was postponed
> to a later patch series: This patch series.
It's good to start running Scalar builds and tests during CI before
moving from contrib/. We can establish a pattern that the code is
not causing build failures, and demonstrate that the tests succeed
consistently. Better to do that while still in the mode where we can
easily reverse course.
Show 6 quoted lines
> Note that the changes to the GitHub workflow are somewhat transient in
> nature: Based on the feedback I received on the Git mailing list, I see some
> appetite for turning Scalar into a full-fledged top-level command in Git,
> similar to gitk. Therefore my current plan is to do exactly that in the end
> (and I already have patches lined up to that end). This will essentially
> revert the ci/run-build-and-tests.sh change in this patch series.

I expect that this won't be a full remote, since we will still want to exclude Scalar from the build without INCLUDE_SCALAR enabled.

Thanks, -Stolee

Previous: Johannes SchindelinNext: Ævar Arnfjörð Bjarmason
Message 8 of 14 in “Integrate Scalar into the CI builds”
  1. 0/2 Integrate Scalar into the CI buildsJohannes Schindelin via GitGitGadget, Jun 2, 2022
  2. 1/2 cmake: optionally build `scalar`, tooJohannes Schindelin via GitGitGadget, Jun 2, 2022
  3. Ævar Arnfjörð BjarmasonJun 2, 2022
  4. 2/2 ci: also run the `scalar` testsJohannes Schindelin via GitGitGadget, Jun 2, 2022
  5. Ævar Arnfjörð BjarmasonJun 2, 2022
  6. Derrick StoleeJun 2, 2022
  7. Johannes SchindelinJun 3, 2022
  8. Derrick StoleeJun 2, 2022
  9. Ævar Arnfjörð BjarmasonJun 2, 2022
  10. Derrick StoleeJun 2, 2022
  11. Johannes SchindelinJun 3, 2022
  12. Ævar Arnfjörð BjarmasonJun 3, 2022
  13. Johannes SchindelinJun 13, 2022
  14. Ævar Arnfjörð BjarmasonJun 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.