Re: [PATCH v2 3/3] Makefile: replace most hardcoded object lists with $(wildcard)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 10, 2021, 14:59 UTC
Message-ID: <nycvar.QRO.7.76.6.2111101547120.21127@tvgsbejvaqbjf.bet>
In-Reply-To: <211110.86h7cki0uo.gmgdl@evledraar.gmail.com>

Hi Ævar,

On Wed, 10 Nov 2021, Ævar Arnfjörð Bjarmason wrote:

> If we're not OK with $(wildcard) as a pattern that would mean changing
> all of these to hardcoded (in some cases quite big) lists somewhere:
>
>     [...]

No, it would only mean changing these instances if we have a concrete need. I fail to see a concrete need.

That does not mean that we should make the situation even worse by converting currently hard-coded lists to wildcards. There is, once again, no concrete need for that, and there is the good reason Junio brought up against such a churn: it is too sloppy.

> [...] I think we should remove that LIB_H thing entirely.

I think we should take a break from refactoring code where it is unclear what purpose the refactoring serves.

Show 7 quoted lines

> > And to be honest, even `LIB_H` and `FIND_SOURCE_FILE` would quite
> > potentially better be hard-coded (with a CI check to ensure that
> > they're up to date).
>
> That would be a bug, just because I don't build on Windows doesn't mean
> that I wouldn't like "make TAGS coccicheck" to find compat/win32/ at
> all.

Talking about `coccicheck` in the context of the discussion whether we should make sweeping changes in our Makefiles, all while we're supposedly in the -rc phase, strikes me as a distant tangent of a distant tangent.

Ciao, Johannes