Re: [PATCH v2 3/3] Makefile: replace most hardcoded object lists with $(wildcard)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 10, 2021, 12:39 UTC
Message-ID: <nycvar.QRO.7.76.6.2111101332130.21127@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqtugl102l.fsf@gitster.g>

Hi Junio,

On Tue, 9 Nov 2021, Junio C Hamano wrote:

> Allowing to be sloppy while maintaining Makefile feels like a false
> economy, and having to paper it over by adding exceptions and
> forcing developers to learn such ad-hoc rules even more so.

If you ever needed another opinion to back you up on this: I fully agree.

> If we could use "git ls-files" consistently, that may make it
> somewhat safer; you'd at least need to "git add" a new file before
> it gets into the picture.  But it would be impossible, because we
> need to be able to bootstrap Git from a tarball extract.

Indeed, the ability to build from a `.tar` extract is important. That's why we were careful to use `ls-files` in `LIB_H` and in `FIND_SOURCE_FILE`, falling back on using `find` if the `ls-files` call failed.

And to be honest, even `LIB_H` and `FIND_SOURCE_FILE` would quite potentially better be hard-coded (with a CI check to ensure that they're up to date).

Ciao, Dscho