Re: [PATCH] Makefile: replace most hardcoded object lists with $(wildcard)

From: Philip Oakley <philipoakley@iee.email>
Date: Nov 4, 2021, 14:29 UTC
Message-ID: <45402a12-e08a-bb27-09cf-db1c64c76bba@iee.email>
In-Reply-To: <211104.86r1bwi6f7.gmgdl@evledraar.gmail.com>

On 04/11/2021 09:46, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

>> he entire point of the CMake configuration is to allow developers on
>> Windows to use the tools they are used to, to build Git. And believe it or
>> not, GNU make is not one of those tools! I know. Very hard to believe. :-)
> I believe that, the question is why it isn't a better trade-off to just
> ask those users to install that software. Our Windows CI is doing it
> on-the-fly, so clearly it's not that hard to do it.

Just to say that, while it is real easy to download and install the Git-for-Windows SDK (https://gitforwindows.org/#download-sdk), for most (Windows) users it's a foreign land, with few friends who understand what things like `gdb` are all about. It's all doable, but the learning curve can be hard. The CI doesn't need a learning curve ;-)

Being able to fire up a well 'trusted' tool like Visual Studio to investigate the code does help contributors understand the code.

-- Philip