git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] fixup! reftable: rest of library

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 1, 2020, 14:24 UTC
Message-ID
<nycvar.QRO.7.76.6.2012011519340.54@tvgsbejvaqbjf.bet>
In-Reply-To
<X8Ya24TJd87hRq7H@coredump.intra.peff.net>
Hi Peff,
On Tue, 1 Dec 2020, Jeff King wrote:
Show 13 quoted lines
> On Sat, Nov 28, 2020 at 06:44:38AM +0000, Johannes Schindelin via GitGitGadget wrote:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > The stack_test hard-codes `/tmp/`. That is a particular problem on
> > Windows where the temp directory is never at that location.
> >
> > Let's not do that, but instead use `TMPDIR` as we do in similar
> > scenarios in the rest of Git's source code.
>
> Yeah, I noticed this, as well. This seems like a good band-aid, but it
> would probably be nice if the test tool was able to write into a
> specified directory (or even just the current directory).

You can force it to do that by setting `TMPDIR` to the path of the current directory...

> I don't see it being invoked anywhere,

It is invoked in `t/t0032-reftable-unittest.sh`: https://github.com/dscho/git/blob/reftable-on-windows/t/t0032-reftable-unittest.sh

> but presumably if we were to add support to our test suite, we'd have a
> script which invokes it within a scratch directory.

I agree that it would make most sense for t0032 to prefix the call to `test-tool` with `TMPDIR=$PWD`.

Ciao, Dscho

Previous: Jeff KingNext: Jeff King
Message 10 of 22 in “Minimal patches to let reftable pass the CI builds”
  1. 0/6 Minimal patches to let reftable pass the CI buildsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  2. 1/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  3. Han-Wen NienhuysDec 1, 2020
  4. Johannes SchindelinDec 2, 2020
  5. Reftable locking on Windows (Re: [PATCH 1/6] fixup! reftable: rest of library)Han-Wen Nienhuys, Dec 2, 2020
  6. Ævar Arnfjörð BjarmasonDec 3, 2020
  7. Han-Wen NienhuysDec 3, 2020
  8. 6/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  9. Jeff KingDec 1, 2020
  10. Johannes SchindelinDec 1, 2020
  11. Jeff KingDec 2, 2020
  12. Han-Wen NienhuysDec 2, 2020
  13. Jeff KingDec 2, 2020
  14. 4/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  15. 2/6 fixup! reftable: utility functionsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  16. 3/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  17. Jeff KingDec 1, 2020
  18. Han-Wen NienhuysDec 1, 2020
  19. Jeff KingDec 1, 2020
  20. 5/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  21. Han-Wen NienhuysNov 30, 2020
  22. Johannes SchindelinDec 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.