git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] Minimal patches to let reftable pass the CI builds

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Nov 30, 2020, 14:26 UTC
Message-ID
<CAFQ2z_M8N-9pCh=+rQvGoOJNYAxnMo1upJPEgsqMT9VxP5X=YA@mail.gmail.com>
In-Reply-To
<pull.801.git.1606545878.gitgitgadget@gmail.com>

On Sat, Nov 28, 2020 at 7:44 AM Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 23 quoted lines
>
> These patches fix the PR build failures at
> https://github.com/git/git/pull/847/checks?check_run_id=1460683728, and are
> designed to be squashed into the 16 patches of the libreftable v3 patch
> series as submitted at
> https://lore.kernel.org/git/pull.847.v3.git.git.1606419752.gitgitgadget@gmail.com/
> .
>
> A smaller form of the first patch was offered on the mailing list on May
> 4th:
> https://lore.kernel.org/git/ff60fde10919b6b8c54ecb8f38b710fac37624e3.1588599086.git.gitgitgadget@gmail.com/
> . The next three patches were presented to the mailing list on October 2nd:
> https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010021555290.50@tvgsbejvaqbjf.bet/
> , and
> https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010021557570.50@tvgsbejvaqbjf.bet/
> . Some of the patches required slight adjustments to accommodate for context
> changes.
>
> Going forward, I would like to avoid the impression that it is the
> responsibility of the Git for Windows maintainer to keep the CI build
> passing on Windows. I am happy to assist in case it is unclear how to fix
> certain issues. I am not happy having to implement and test those fixes
> myself. How can we ensure this doesn't happen in the future?

Thanks for the build system fix. I think it's OK to leave it to me to solve the logic problems in the C code that you found.

Would you mind if I massaged these contributions directly back into github.com/google/reftable? Google has a corporate CLA from Microsoft, it's OK to accept this from you. For better or worse, this is still where I'm developing reftable, until it has landed in git-core.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin
Message 21 of 22 in “Minimal patches to let reftable pass the CI builds”
  1. 0/6 Minimal patches to let reftable pass the CI buildsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  2. 1/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  3. Han-Wen NienhuysDec 1, 2020
  4. Johannes SchindelinDec 2, 2020
  5. Reftable locking on Windows (Re: [PATCH 1/6] fixup! reftable: rest of library)Han-Wen Nienhuys, Dec 2, 2020
  6. Ævar Arnfjörð BjarmasonDec 3, 2020
  7. Han-Wen NienhuysDec 3, 2020
  8. 6/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  9. Jeff KingDec 1, 2020
  10. Johannes SchindelinDec 1, 2020
  11. Jeff KingDec 2, 2020
  12. Han-Wen NienhuysDec 2, 2020
  13. Jeff KingDec 2, 2020
  14. 4/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  15. 2/6 fixup! reftable: utility functionsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  16. 3/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  17. Jeff KingDec 1, 2020
  18. Han-Wen NienhuysDec 1, 2020
  19. Jeff KingDec 1, 2020
  20. 5/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  21. Han-Wen NienhuysNov 30, 2020
  22. Johannes SchindelinDec 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.