git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] fixup! reftable: rest of library

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Dec 2, 2020, 11:01 UTC
Message-ID
<CAFQ2z_P3WmSyBJvhCQi-rOQRvUwbK9RH6CGvS2Br0zW-=xwa4A@mail.gmail.com>
In-Reply-To
<X8by+j24ccvt0F04@coredump.intra.peff.net>
On Wed, Dec 2, 2020 at 2:50 AM Jeff King <peff@peff.net> wrote:
Show 20 quoted lines
> > > I don't see it being invoked anywhere,
> >
> > It is invoked in `t/t0032-reftable-unittest.sh`:
> > https://github.com/dscho/git/blob/reftable-on-windows/t/t0032-reftable-unittest.sh
>
> Ah, thank you. I was looking at what Junio has queued in hn/reftable.
>
> > > but presumably if we were to add support to our test suite, we'd have a
> > > script which invokes it within a scratch directory.
> >
> > I agree that it would make most sense for t0032 to prefix the call to
> > `test-tool` with `TMPDIR=$PWD`.
>
> Yep, that would be fine.
>
> I'm not sure if the long-term goal is to have this opaque unit-test
> program or not. If it is, I was likewise going to suggest that its
> ad-hoc output be replaced with TAP. But it looks like on your branch
> that "test-tool reftable" does not produce output at all. So I may be a
> bit behind on what the current state and forward plans are...

The most important requirement is that something fails if the unittests don't work. I surmised that that meant running tests from test-helper in some way, so this is what happens now. Looking for "unit.?test" across the git codebase didn't turn up much info. Happy to explore other solutions if you can give me pointers.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Jeff KingNext: Jeff King
Message 12 of 22 in “Minimal patches to let reftable pass the CI builds”
  1. 0/6 Minimal patches to let reftable pass the CI buildsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  2. 1/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  3. Han-Wen NienhuysDec 1, 2020
  4. Johannes SchindelinDec 2, 2020
  5. Reftable locking on Windows (Re: [PATCH 1/6] fixup! reftable: rest of library)Han-Wen Nienhuys, Dec 2, 2020
  6. Ævar Arnfjörð BjarmasonDec 3, 2020
  7. Han-Wen NienhuysDec 3, 2020
  8. 6/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  9. Jeff KingDec 1, 2020
  10. Johannes SchindelinDec 1, 2020
  11. Jeff KingDec 2, 2020
  12. Han-Wen NienhuysDec 2, 2020
  13. Jeff KingDec 2, 2020
  14. 4/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  15. 2/6 fixup! reftable: utility functionsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  16. 3/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  17. Jeff KingDec 1, 2020
  18. Han-Wen NienhuysDec 1, 2020
  19. Jeff KingDec 1, 2020
  20. 5/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  21. Han-Wen NienhuysNov 30, 2020
  22. Johannes SchindelinDec 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.